Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tibble problem #93

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix tibble problem #93

merged 1 commit into from
Oct 28, 2023

Conversation

mayer79
Copy link
Collaborator

@mayer79 mayer79 commented Oct 28, 2023

Selecting w and BY via column names would fail for tibbles. This is fixed here.

Fixes #92

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0767d35) 96.87% compared to head (557b66c) 96.68%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   96.87%   96.68%   -0.19%     
==========================================
  Files          18       18              
  Lines         959      965       +6     
==========================================
+ Hits          929      933       +4     
- Misses         30       32       +2     
Files Coverage Δ
R/utils_input.R 94.11% <77.77%> (-5.89%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayer79 mayer79 merged commit 9fcab31 into main Oct 28, 2023
@mayer79 mayer79 deleted the tibble branch October 28, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partial_dep() with BY argument: error for tibble X argument
2 participants